fix: remove redundant physicalType field #610
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the conversion of HL7 messages to FHIR resources, I found that the template DataType/PL_HDLocation defines the field physicalType, even though this property is already included in PLLocation. This duplication leads to physicalType being generated twice in the same resource (as an array).
Root Cause
PLLocation already includes physicalType.
When DataType/PL_HDLocation is rendered inside PLLocation, it introduces another physicalType.
The same applies when DataType/PL_HDLocation is called from NDLocation.
Fix
Removed the physicalType field from DataType/PL_HDLocation.
Impact
Prevents duplicate physicalType fields in FHIR resources.
Safe change: both PLLocation and NDLocation already handle physicalType.
No edge cases identified where DataType/PL_HDLocation requires its own physicalType.