fix: Dev to main #466
Merged
fix: Dev to main #466
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: CI Pipeline Validate Deployment - DKM
fix: Change CreatedBy tag logic in bicep
NirajC-Microsoft
requested review from
Avijit-Microsoft,
Dongbumlee,
Prajwal-Microsoft,
Roopan-Microsoft,
Vinay-Microsoft and
aniaroramsft
as code owners
fix: added new 'type' tag for WAF and Non-WAF deployement
Roopan-Microsoft
approved these changes
Sep 24, 2025
|
🎉 This PR is included in version 1.1.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces improvements to the deployment workflow and infrastructure template to enhance resource tagging and make the
createdByparameter more robust. The changes ensure that deployments are better tracked with accurate metadata and that the infrastructure tags reflect the current configuration.Deployment workflow and tagging enhancements:
.github/workflows/CI.ymlto generate a UTC timestamp in the formatYYYY-MM-DDTHH:MM:SS.SSSSSSSZfor use in deployment tags.tagsparameter, adding metadata such asSecurityControl,Purpose, and the generatedCreatedDatetimestamp.Infrastructure template improvements:
createdByparameter ininfra/main.bicepto use the deployer's username if available, otherwise fallback to the deployer's object ID for more reliable identification.TemplateNametag to reflect whether private networking is enabled, setting it to'DKM-WAF'if enabled, otherwise'DKM'.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information