add shieldGuard changes #1287
Merged
add shieldGuard changes #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganga1980
previously approved these changes
Jul 9, 2024
ganga1980
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on enhancing the security of various Kubernetes deployments by modifying the
securityContextin multiple YAML files. The changes involve dropping all capabilities and adding theDAC_OVERRIDEcapability.Security enhancements:
charts/azuremonitor-containers/templates/ama-logs-daemonset-windows.yaml: Added asecurityContextto drop all capabilities and addDAC_OVERRIDE.charts/azuremonitor-containers/templates/ama-logs-daemonset.yaml: Modified thesecurityContextin two places to drop all capabilities and addDAC_OVERRIDE. [1] [2]charts/azuremonitor-containers/templates/ama-logs-deployment.yaml: Updated thesecurityContextto drop all capabilities and addDAC_OVERRIDE.kubernetes/ama-logs.yaml: ThesecurityContextin four places was changed to drop all capabilities and addDAC_OVERRIDE. [1] [2] [3] [4]These changes are important as they help to limit the capabilities of the containers, thereby reducing potential security risks. The
DAC_OVERRIDEcapability allows the containers to bypass file read, write, and execute permission checks on the user and group owner.