Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs #1230

Merged
merged 3 commits into from
Apr 18, 2024
Merged

fix bugs #1230

merged 3 commits into from
Apr 18, 2024

Conversation

ganga1980
Copy link
Contributor

This PR has following changes

  1. Default retry limit to 10 instead of infinite as this can cause ama-logs daemonset OOMing if the ama-logs-geneva service unreachable
  2. update the comment in azuremonitor-containers-geneva chart values yaml

@ganga1980 ganga1980 requested a review from a team as a code owner April 17, 2024 02:26
jatakiajanvi12
jatakiajanvi12 previously approved these changes Apr 17, 2024
View reviewed changes
jatakiajanvi12
jatakiajanvi12 previously approved these changes Apr 17, 2024
View reviewed changes
@ganga1980 ganga1980 enabled auto-merge (squash) April 17, 2024 21:44
@ganga1980 ganga1980 merged commit 860d1e8 into ci_prod Apr 18, 2024
15 checks passed
jatakiajanvi12 pushed a commit that referenced this pull request May 10, 2024
@ganga1980 @jatakiajanvi12
fix bugs (#1230)
c8ec1e9 
* fix bugs

* fix comment
jatakiajanvi12 added a commit that referenced this pull request May 10, 2024
@jatakiajanvi12
Revert "fix bugs (#1230)"
4db110f 
This reverts commit c8ec1e9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pfrcks pfrcks pfrcks approved these changes

@jatakiajanvi12 jatakiajanvi12 jatakiajanvi12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganga1980 @pfrcks @jatakiajanvi12