[CMake] Fix MSVC runtime library selection - #8804
Draft
Alex Sepkowski (alsepkow) wants to merge 1 commit into
Draft
[CMake] Fix MSVC runtime library selection#8804Alex Sepkowski (alsepkow) wants to merge 1 commit into
Alex Sepkowski (alsepkow) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 0f4d0e10-e926-4bce-b36b-0abebc08f6dc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the existing
LLVM_USE_CRT_<CONFIG>settings control the MSBuild runtime-library property generated by modern CMake.CMake's
CMP0091runtime-library abstraction emits<RuntimeLibrary>in Visual Studio projects. The currentChooseMSVCCRT.cmakeimplementation instead editsCMAKE_<LANG>_FLAGS_<CONFIG>, which can leave an explicit/MTcompeting with CMake's generated/MDselection. Translate the existingMD,MDd,MT, andMTdvalues toCMAKE_MSVC_RUNTIME_LIBRARYso the requested runtime is authoritative. Configurations without an explicit override retain CMake's normal DLL-runtime defaults.Testing:
LLVM_USE_CRT_RELEASE=MT.llvm-tblgen.vcxprojcontains<RuntimeLibrary>MultiThreaded</RuntimeLibrary>while Debug remainsMultiThreadedDebugDLL.llvm-tblgentarget successfully.dumpbin /dependentsreports onlyKERNEL32.dll, with noVCRUNTIMEorMSVCPimports.No release note is needed because this fixes build-system behavior rather than compiler-visible behavior.