[SER] HitObject::GetAttributes HLSL -> DXIL lowering and attributes sema #7361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HLSL -> DXIL lowering - ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests SER implementation tracker (microsoft#7214)
Co-authored-by: Chris B <beanz@abolishcrlf.org>
This reverts commit 57b5fdd.
…return is a Clang codegen artifact)
simoll
changed the title
tex3d
reviewed
Apr 21, 2025
There was a problem hiding this comment.
- We need a dxilgen pass test to test the lowering in isolation.
- I think we need to change the form of the
GetAttributesmethod to take anout udtparameter instead of following theByteAddressBuffer::Loadpattern and returning$funcT, which returns a reference, then pointer for HL op. For this point, we could defer until after preview, but I think we need to file a spec issue for follow-up.
tools/clang/test/SemaHLSL/hlsl/objects/HitObject/hitobject_attributes.hlsl
Show resolved
Hide resolved
tex3d
approved these changes
Apr 22, 2025
llvm-beanz
approved these changes
Apr 22, 2025
|
@simoll, one of the introduced tests is failing, can you fix that up? |
Fixed it. A diagnostic signature changed here while the traceinvoke PR added another instance of that diagnostic. Merged main and fixed that use too. |
llvm-beanz
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowering for
HitObject::GetAttributes<T>()Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md
DXC SER implementation tracker:: #7214