Satisfied warnings & errors for updated dxrflcompiler #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgerd
force-pushed
the
develop-dxr-compilerFixes
branch
from
038da91
to
8480822
Compare
rgerd
changed the title
|
Verified with Robert that, while this validation was added for the new compiler, it also works with the old compiler (so we don't have some additional versioning problem introduced here. No action |
pkristof
suggested changes
Jul 19, 2018
| @@ -90,6 +90,39 @@ float4 CalculatePhongLighting(in float4 albedo, in float3 normal, in bool isInSh | |||
| return ambientColor + diffuseColor + specularColor; | |||
| } | |||
|
|
|||
| // Load three 16 bit indices. | |||
There was a problem hiding this comment.
Does the sample fail to compile with the helper function being in the helper header? If not, this is not desired. This was put to a helper header as the samples move code introduced in previous samples and code that is not of the primary goal of the sample to helpers to make the new sample focused on what it's trying to show and keep the code footprint small(er) in the primary source files .
pkristof
approved these changes
Jul 20, 2018
rgerd
force-pushed
the
develop-dxr-compilerFixes
branch
2 times, most recently
from
380f166
to
971e090
Compare
clandrew
approved these changes
Jul 20, 2018
rgerd
force-pushed
the
develop-dxr-compilerFixes
branch
from
971e090
to
fe8a6e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
staticto function definitions using resource types (i.e. RWByteAddressBufferPointer) in parameters or return type to force inlining so that the compiler doesn't get upsetDispatched rays are now indexed in 3d, but our shaders only need the first two dimensions (so far)
Brought in changes from develop-dxr