Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade toolset #259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade toolset #259

wants to merge 1 commit into from

Conversation

AreaZR
Copy link

@AreaZR AreaZR commented Oct 9, 2022

Use v143 instead of v142

Microsoft Reviewers: Open in CodeFlow

Use v143 instead of v142
@AreaZR
Copy link
Author

AreaZR commented Oct 17, 2022

@fishjam @JohnMcPMS could you please take a look?

@fishjam
Copy link
Contributor

fishjam commented Oct 18, 2022

@fishjam @JohnMcPMS could you please take a look?

@AtariDreams sorry, I'm not the owner.
And if you want upgrade the toolset, I think you need provide the reason.

@AreaZR
Copy link
Author

AreaZR commented Oct 23, 2022

@fishjam @JohnMcPMS could you please take a look?

@AtariDreams sorry, I'm not the owner. And if you want upgrade the toolset, I think you need provide the reason.

v143 has many improvements over 142 and most projects using this need 2 compilers as a result of importing Detours

@sylveon
Copy link
Contributor

sylveon commented Oct 23, 2022

If you're using nmake or vcpkg to build the library, it should already be building using vs 2022.

@AreaZR
Copy link
Author

AreaZR commented Oct 24, 2022

But this is with v142, not v143

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants