-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove formatting rules rules from dtslint #699
feat: remove formatting rules rules from dtslint #699
Conversation
@@ -14,33 +13,12 @@ | |||
|
|||
"comment-format": [true, "check-space"], // But not check-uppercase or check-lowercase | |||
"interface-name": [true, "never-prefix"], | |||
"max-line-length": [true, 200], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kinda funky that we have 200 here but 120 in the prettier config (and now dprint config). Of course, I personally use 120 so 🤫
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this shortly before the first dprint PR on DT goes in.
@@ -1,86 +0,0 @@ | |||
import * as Lint from "tslint"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aha, so that's what the other dtslint rules were doing!
@JoshuaKGoldberg if I understand correctly, this should be a follow-up PR DefinitelyTyped/DefinitelyTyped#66514 right? |
Aha, yes, I'd started on a followup PR to DT that removes all of these no-longer-present rules. |
Targets a bit of both of: