Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing changeset CI PR check #1080

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jakebailey
Copy link
Member

@jakebailey jakebailey commented Oct 14, 2024

This workflow was checking origin/main rather than the merge base of the PR; due to race conditions or other timing issues with manual CI run approval, we may end up in a situation where the two are different, leading to other unrelated changes showing up in the diff during the changeset check. (Like https://github.com/microsoft/DefinitelyTyped-tools/actions/runs/11257648935/job/31524626555?pr=1075)

@jakebailey jakebailey merged commit d59f5ad into microsoft:main Oct 14, 2024
8 checks passed
@jakebailey jakebailey deleted the fix-changeset-ci branch October 14, 2024 22:42
@jakebailey
Copy link
Member Author

Merged to unblock #1075, which it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant