remove array-type eslint rule #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iisaduan
requested review from
sandersn,
jakebailey and
andrewbranch
as code owners
|
Isn't this error right? This will also disable the style rule we prefer on DT (not that I like it myself) |
The error message changes when you remove the
|
|
typescript-eslint/typescript-eslint#9498 I filed a bug |
jakebailey
reviewed
Jul 8, 2024
sandersn
approved these changes
Jul 8, 2024
|
Updated the PR so we can get it in. |
jakebailey
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
"array-type":"error"behavior, seems to have changed in the most recent typescript-eslint release, and as a result, it is generating new errors.With the addition of the default setting, the error message also becomes wrong:
