Add find_unused_parameters option to DeepSpeedEngine #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from base
As unused parameters in modules may not be expected sometimes, add an explicit error msg when it occurred and an option to avoid the error: microsoft#707
As unused parameters in modules may not be expected sometimes, add an explicit error msg when it occurred and an option to avoid the error: microsoft#707
ghosthamlet
requested review from
arashashari,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
RezaYazdaniAminabadi,
samyam,
ShadenSmith and
tjruwase
as code owners
|
|
|
I can't find where was the yapf error in my commit code, also no error when run yapf local, it is strange. |
|
Ok, Fixed it. |
|
@ghosthamlet, thanks for this feature. Rather than modifying DeepSpeed engine, can you please add this configuration to the zero options? That is a more appropriate place since the issue only affects zero stage 2. Thanks. |
|
@tjruwase Thanks for the review, i changed it, please review again. |
tjruwase
reviewed
Apr 24, 2021
|
Thanks for making the changes. One final request can you also add a unit test? |
Ok, let me find out how the test works and add it. |
|
@tjruwase Test added, please review again. |
tjruwase
approved these changes
Apr 25, 2021
|
@ghosthamlet, please note the impact of #1039 on this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As unused parameters in modules may not be expected sometimes,
add an explicit error msg when it occurred and an option to avoid the error: #707