-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uneven head sequence parallelism bug (#6774) #6797
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #6774 |
LGTM, Many thanks! |
inkcherry
reviewed
Dec 2, 2024
loadams
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here
gather_idx < 2
representsis_first_all2all
. During the first all2all,uneven_head_all2all
will be called if eithernum_heads % seq_world_size != 0
orget_num_kv_heads() is None
.During the second all2all, it'll return return
uneven_head_all2all
if and only ifget_num_kv_heads() is None
which is always set during the first uneven all2all. This means that there will no longer be issue whereuneven_head_all2all
is returned for the second all2all because ofnum_heads % seq_world_size != 0
.Fixes: #6774