Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin transformers version to work around latest torch requirements #6759

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

loadams
Copy link
Contributor

@loadams loadams commented Nov 18, 2024

Latest transformers seems to break our tests that aren't on torch latest (>= 2.5). Issue opened here: huggingface/transformers#34795. This pins our version so these tests can pass in the meantime.

@loadams loadams marked this pull request as ready for review November 19, 2024 00:23
@loadams loadams changed the title Transformers requires torch 2.5 Pin transformers version to work around latest torch requirements Nov 19, 2024
@loadams loadams enabled auto-merge November 19, 2024 00:38
@loadams loadams added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit 8488bee Nov 19, 2024
12 checks passed
@loadams loadams deleted the loadams/transformers-bug branch November 19, 2024 15:06
loadams added a commit that referenced this pull request Nov 22, 2024
Reverts #6759

Requires from transformers: 
huggingface/transformers#34816
huggingface/transformers#34800

Todo:
- [x] Need to merge first PR to get support for torch 2.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants