Add first Step in LR Schedulers #6597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Oct 1, 2024
tohtana
reviewed
Oct 8, 2024
| @@ -675,11 +675,16 @@ def __init__(self, | |||
| self.warmup_type = warmup_type | |||
| self.inverse_log_warm_up = 1.0 / math.log(self.warmup_num_steps) | |||
| self.last_batch_iteration = last_batch_iteration | |||
| # Initialize lr in optimizer | |||
There was a problem hiding this comment.
These changes are duplicated. Can we extract the code as a function and reuse it?
tohtana
reviewed
Oct 8, 2024
deepspeed/runtime/lr_schedules.py
Outdated
| @@ -851,15 +851,17 @@ def get_lr_ratio(self): | |||
| ratio = max(0.0, self.cos_min_ratio + ratio_delta * ratio) | |||
| return ratio | |||
|
|
|||
| def update_lr(self): | |||
There was a problem hiding this comment.
Can we also consolidate this with the previous one?
tohtana
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some (not all) of the LR schedulers in runtime were missing the initialization of the optimizer group lr.