Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROCm] Fix subprocess error #6587

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[ROCm] Fix subprocess error #6587

merged 1 commit into from
Oct 4, 2024

Conversation

jagadish-amd
Copy link
Contributor

Fixes #6585
Use shell=True for subprocess.check_output() in case of ROCm commands. Do not use shlex.split() since command string has wildcard expansion.

@jagadish-amd
[ROCm] Fix subprocess error
cb0074c 
Fixes microsoft#6585
Use shell=True for subprocess.check_output() in case of ROCm
commands. Do not use shlex.split() since command string has
wildcard expansion.

Signed-off-by: Jagadish Krishnamoorthy <jagadish.krishnamoorthy@amd.com>
@jagadish-amd
Copy link
Contributor Author

ping @tjruwase @loadams @jithunnair-amd

jithunnair-amd
jithunnair-amd reviewed Sep 28, 2024
View reviewed changes
Copy link
Contributor

@jithunnair-amd jithunnair-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jagadish-amd
Copy link
Contributor Author

There are bunch of nv jobs with failed status. I am not able to view the logs.
It should not be related to my changes since its only affects ROCm.
Requesting to merge the PR if the log suggests the same.
cc @loadams

@loadams
Copy link
Contributor

loadams commented Sep 30, 2024

There are bunch of nv jobs with failed status. I am not able to view the logs. It should not be related to my changes since its only affects ROCm. Requesting to merge the PR if the log suggests the same. cc @loadams

Hi @jagadish-amd - sorry, the runners crashed while running your jobs before, and need to be recovered. I'm trying to fix that and if we can't get it fixed quickly we can force merge this

@jagadish-amd
Copy link
Contributor Author

There are bunch of nv jobs with failed status. I am not able to view the logs. It should not be related to my changes since its only affects ROCm. Requesting to merge the PR if the log suggests the same. cc @loadams

Hi @jagadish-amd - sorry, the runners crashed while running your jobs before, and need to be recovered. I'm trying to fix that and if we can't get it fixed quickly we can force merge this

Thanks @loadams !

@jithunnair-amd
Copy link
Contributor

@loadams Can we merge this PR now?

@loadams loadams mentioned this pull request Oct 4, 2024
Closed
@loadams loadams merged commit b93c7a2 into microsoft:master Oct 4, 2024
9 of 12 checks passed
@jagadish-amd jagadish-amd deleted the fix-rocm-subprocess branch October 5, 2024 05:33
@jithunnair-amd jithunnair-amd mentioned this pull request Oct 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jithunnair-amd jithunnair-amd jithunnair-amd left review comments

@loadams loadams loadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] subprocess.CalledProcessError
3 participants
@jagadish-amd @loadams @jithunnair-amd