Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change GDS to 1 AIO thread #6459

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Change GDS to 1 AIO thread #6459

merged 2 commits into from
Aug 29, 2024

Conversation

jomayeri
Copy link
Contributor

@jomayeri jomayeri commented Aug 28, 2024

The numThreads config option determines how many threads are used to read from the file. In the CPU case these threads are created via AIO, in the GDS case they are handled by the GDS library via the cufile.json. If we were to also create AIO threads it would have a multiplicative effect. Example 8 AIO threads * 8 GDS threads would be 64 threads reading from the file when the user really only intended for 8 threads.

@jomayeri jomayeri requested a review from tjruwase August 28, 2024 21:23
@tjruwase tjruwase removed request for arashb and awan-10 August 29, 2024 00:01
@jomayeri jomayeri added this pull request to the merge queue Aug 29, 2024
github-merge-queue bot pushed a commit that referenced this pull request Aug 29, 2024
The `numThreads` config option determines how many threads are used to
read from the file. In the CPU case these threads are created via AIO,
in the GDS case they are handled by the GDS library via the cufile.json.
If we were to also create AIO threads it would have a multiplicative
effect. Example 8 AIO threads * 8 GDS threads would be 64 threads
reading from the file when the user really only intended for 8 threads.

Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@loadams loadams added this pull request to the merge queue Aug 29, 2024
Merged via the queue into master with commit f2739b4 Aug 29, 2024
11 checks passed
@jomayeri jomayeri deleted the jomayeri/single-cxtx-gds branch August 29, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants