Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid gds build errors on ROCm #6456

Merged
merged 5 commits into from
Aug 29, 2024
Merged

Avoid gds build errors on ROCm #6456

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e1d1ce
Avoid errors in DeepSpeed build on ROCm
rraminen Aug 28, 2024
dc1b768
Merge branch 'master' into DeepSpeed_rocm_gds_fix
loadams Aug 28, 2024
1d2399c
Revert "Avoid errors in DeepSpeed build on ROCm"
rraminen Aug 28, 2024
33622c8
gds is not compatible with ROCM
rraminen Aug 28, 2024
fb13723
Merge branch 'master' into DeepSpeed_rocm_gds_fix
loadams Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions op_builder/gds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,13 @@ def is_compatible(self, verbose=False):
self.warning("Please install torch if trying to pre-compile GDS")
return False

CUDA_HOME = torch.utils.cpp_extension.CUDA_HOME
CUDA_LIB64 = os.path.join(CUDA_HOME, "lib64")
if not self.is_rocm_pytorch():
CUDA_HOME = torch.utils.cpp_extension.CUDA_HOME
CUDA_LIB64 = os.path.join(CUDA_HOME, "lib64")
else:
loadams marked this conversation as resolved.
Show resolved Hide resolved
CUDA_HOME = torch.utils.cpp_extension.ROCM_HOME
CUDA_LIB64 = os.path.join(CUDA_HOME, "lib")

gds_compatible = self.has_function(funcname="cuFileDriverOpen",
libraries=("cufile", ),
library_dirs=(
Expand Down
Loading