Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add workflow to build DS without torch to better test before releases #6450

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Add workflow to build DS without torch to better test before releases #6450

merged 10 commits into from
Aug 30, 2024

Conversation

loadams
Copy link
Contributor

@loadams loadams commented Aug 27, 2024 •
edited
Loading

  • Adds a nightly workflow that tests to confirm we can build DeepSpeed without torch as a dependency, as this often only surfaces when doing a release.

sfc-gh-mwyatt
sfc-gh-mwyatt reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@sfc-gh-mwyatt sfc-gh-mwyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loadams loadams added this pull request to the merge queue Aug 29, 2024
Merged via the queue into master with commit 9b7fc54 Aug 30, 2024
12 checks passed
@loadams loadams deleted the loadams/no-torch-workflow branch September 27, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-mwyatt sfc-gh-mwyatt sfc-gh-mwyatt left review comments

@jomayeri jomayeri jomayeri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loadams @jomayeri @sfc-gh-mwyatt