add moe topk(k>2) gate support #5881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [MoE] enable topk > 2 gate * print_version * refine code * deepspeed/moe/sharded_moe.py * func verify * refine code * refine code * refine code * refine code * refine code * remove duplicate topk * update * refine code * fix format * update * fix == * update * add ut * rm tt * update * add top3 ut * revert note * remove - --------- Co-authored-by: Kurt Chen <kurt.chen@intel.com> Co-authored-by: Jin, Youzhi <youzhi.jin@intel.com>
tjruwase
requested review from
tohtana
and removed request for
awan-10 and
loadams
tohtana
approved these changes
Aug 15, 2024
|
Thank you @inkcherry for the great contribution! I approved and scheduled merging. |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice some users need to use topk > 2 to train MoE models. For example: https://huggingface.co/Qwen/Qwen2-57B-A14B/blob/main/config.json, this PR adds support for topk (k > 2) gates.