Fix numpy upgrade to 2.0.0 BUFSIZE import error #5680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Yejing-Lai, thanks for the PR. Please add support for older numpy versions. |
Yejing-Lai
force-pushed
the
lyj/fix_numpy
branch
from
f38250e to
396c634
Compare
Added older version support. please kindly review. Thanks~ |
loadams
reviewed
Jun 18, 2024
mrwyattii
approved these changes
Jun 18, 2024
loadams
approved these changes
Jun 18, 2024
adk9
approved these changes
Jun 18, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numpy 2.0.0 removed the BUFSIZE API, replacing it with 'numpy._core.umath.BUFSIZE'.
The minimum numpy version supported by the new code is 1.26.1. If you need to support the lower numpy version, please tell me and we can add another path.