Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chatglm2 & chatglm3 autotp #5540

Merged
merged 18 commits into from
Jul 23, 2024
Merged

Add chatglm2 & chatglm3 autotp #5540

merged 18 commits into from
Jul 23, 2024

Conversation

Yejing-Lai
Copy link
Contributor

This PR aims to enable chatglm2 & chatglm3 autotp. Similar to the phi3, this model uses the chunk MLP layer, so we adjust the weight order by 'shard_mlp_chunk' func. Please kindly review~ Thanks!

@delock
Copy link
Collaborator

delock commented Jun 6, 2024

Hi @loadams , this PR is ready for review. Can this PR be reviewed? Thanks!

@Yejing-Lai
Copy link
Contributor Author

Hi @loadams. The CI error seems like a network issue. Could you rerun the CI? Thanks!

@loadams loadams enabled auto-merge June 18, 2024 16:20
@loadams loadams disabled auto-merge June 18, 2024 16:28
@loadams
Copy link
Contributor

loadams commented Jul 15, 2024

@Yejing-Lai - is this PR ready to be merged?

@Yejing-Lai
Copy link
Contributor Author

is this PR ready to be merged?

Yes. Please merged. Thanks!

@HeyangQin HeyangQin added this pull request to the merge queue Jul 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@loadams loadams enabled auto-merge July 20, 2024 03:05
@loadams loadams added this pull request to the merge queue Jul 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jul 20, 2024
@loadams loadams enabled auto-merge July 20, 2024 23:18
@Yejing-Lai Yejing-Lai mentioned this pull request Jul 22, 2024
Merged
@loadams loadams added this pull request to the merge queue Jul 23, 2024
Merged via the queue into microsoft:master with commit 0d3bb77 Jul 23, 2024
12 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Jul 23, 2024
@Yejing-Lai @loadams
Add new autotp supported model in doc (#5785)
acdf136 
This PR refresh the list of models supported by AutoTP. Newly added
models are:

- mixtral
- yuan
- phi
- qwen2 [reviewing PR #5786 ]
- chatglm2&chatglm3 [reviewing PR #5540 ]

Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delock delock delock left review comments

@loadams loadams loadams approved these changes

@HeyangQin HeyangQin HeyangQin approved these changes

@mrwyattii mrwyattii Awaiting requested review from mrwyattii

@awan-10 awan-10 Awaiting requested review from awan-10

@arashb arashb Awaiting requested review from arashb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Yejing-Lai @delock @loadams @HeyangQin @tjruwase