optimize clip_grad_norm_ function #4915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjruwase
approved these changes
Jan 19, 2024
Optimize clip_grad_norm_ function by removing .item() calls to reduce wait time for the device on the host.
mmhab
force-pushed
the
optimize_clip_grad_norm_
branch
from
2865e2d to
9949642
Compare
|
@tjruwase can test workflows be triggered on this PR? thanks |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@tjruwase can this commit be re-added to merge queue? we could not reproduce the merge queue failure locally, probably some other instability. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Still getting failures that don't reproduce locally. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sorry about the inconvenience, we will take a look. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
Optimize clip_grad_norm_ function by removing .item() calls to reduce wait time for the device on the host. Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
rraminen
pushed a commit
to ROCm/DeepSpeed
that referenced
this pull request
May 9, 2024
Optimize clip_grad_norm_ function by removing .item() calls to reduce wait time for the device on the host. Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com> Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize clip_grad_norm_ function by removing .item() calls to reduce wait time for the device on the host.