Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROCm] Add rocblas header #4538

Merged
merged 2 commits into from
Oct 19, 2023
Merged

[ROCm] Add rocblas header #4538

merged 2 commits into from
Oct 19, 2023

Conversation

rraminen
Copy link
Contributor

@rraminen rraminen commented Oct 18, 2023

Fixes #4507.
Fixes #4513.

cc: @jithunnair-amd

Copy link
Contributor

@jithunnair-amd jithunnair-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@IMbackK
Copy link

IMbackK commented Oct 19, 2023

would #else not make more sense here than testing HIP_PLATFORM_HCC again?
I mean its just in the preprocessor so it dosent matter much.

@IMbackK
Copy link

IMbackK commented Oct 19, 2023

anyhow i can confirm this works!

@loadams loadams enabled auto-merge October 19, 2023 16:49
@loadams loadams added this pull request to the merge queue Oct 19, 2023
Merged via the queue into microsoft:master with commit 3e4a587 Oct 19, 2023
15 checks passed
@rraminen rraminen mentioned this pull request Oct 23, 2023
baodii pushed a commit to baodii/DeepSpeed that referenced this pull request Nov 7, 2023
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
mauryaavinash95 pushed a commit to mauryaavinash95/DeepSpeed that referenced this pull request Feb 17, 2024
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants