Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readthedocs yaml configuration #410

Merged
merged 24 commits into from
Sep 17, 2020
Merged

readthedocs yaml configuration #410

merged 24 commits into from
Sep 17, 2020

Conversation

ShadenSmith
Copy link
Contributor

No description provided.

@ShadenSmith ShadenSmith added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation website Edits to the DeepSpeed website(s) labels Sep 15, 2020
@ShadenSmith ShadenSmith marked this pull request as ready for review September 15, 2020 00:35
jeffra
jeffra reviewed Sep 15, 2020
View reviewed changes
.readthedocs.yml

# Optionally build your docs in additional formats such as PDF
formats:
- pdf
Copy link
Collaborator

@jeffra jeffra Sep 15, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this actually build the docs somewhere in PDF? interesting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! https://docs.readthedocs.io/en/stable/downloadable-documentation.html

arashashari
arashashari approved these changes Sep 15, 2020
View reviewed changes
Copy link
Contributor

@arashashari arashashari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the failing test, otherwise LGTM, and thanks for handling it.

@jeffra
Copy link
Collaborator

jeffra commented Sep 15, 2020

Seems it's failing with this import for some reason:

DeepSpeed/deepspeed/ops/__init__.py

Line 1 in 91b4a93

from ..git_version_info import installed_ops as __installed_ops__

@jeffra jeffra merged commit 5812e84 into microsoft:master Sep 17, 2020
@bobisapotato bobisapotato mentioned this pull request Jan 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arashashari arashashari arashashari approved these changes

@jeffra jeffra jeffra approved these changes

@awan-10 awan-10 Awaiting requested review from awan-10

@cli99 cli99 Awaiting requested review from cli99

@conglongli conglongli Awaiting requested review from conglongli

@eltonzheng eltonzheng Awaiting requested review from eltonzheng

@minjiaz minjiaz Awaiting requested review from minjiaz

@niumanar niumanar Awaiting requested review from niumanar

@RezaYazdaniAminabadi RezaYazdaniAminabadi Awaiting requested review from RezaYazdaniAminabadi

@samyam samyam Awaiting requested review from samyam

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation website Edits to the DeepSpeed website(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShadenSmith @jeffra @arashashari