Fix transformers unit tests #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loadams
reviewed
Aug 2, 2023
| @@ -56,8 +56,6 @@ jobs: | |||
| pip install .[testing] | |||
| # find reqs used in ds integration tests | |||
| find examples/pytorch -regextype posix-egrep -regex '.*(language-modeling|question-answering|summarization|image-classification|text-classification|translation).*/requirements.txt' -exec grep -v 'torch' {} \; | xargs -I {} pip install --upgrade {} | |||
| # force datasets version due to issues | |||
| pip install datasets==2.2.2 | |||
There was a problem hiding this comment.
Did you mean to remove it fully or just un-pin the specific version?
There was a problem hiding this comment.
datasets is a dependency of transformers and will be installed with it. No need to explicitly install it unless we are pinning the version.
loadams
approved these changes
Aug 2, 2023
polisettyvarma
pushed a commit
to polisettyvarma/DeepSpeed
that referenced
this pull request
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our transformers CI workflow had
datasetspinned to an old version. This was causing errors.