Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RuntimeError when using ZeRO Stage3 with mpu: #3564 #3565

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Fix RuntimeError when using ZeRO Stage3 with mpu: #3564 #3565

merged 3 commits into from
Jun 1, 2023

Conversation

eggiter
Copy link
Contributor

@eggiter eggiter commented May 18, 2023

@samadejacobs samadejacobs self-requested a review June 1, 2023 00:45
samadejacobs
samadejacobs approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@samadejacobs samadejacobs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eggiter
Copy link
Contributor Author

eggiter commented Jun 1, 2023

@samadejacobs Please approves the workflows since i reformat the changed files to make formatting happy. Thanks.

@tjruwase tjruwase enabled auto-merge (squash) June 1, 2023 02:16
@eggiter
Copy link
Contributor Author

eggiter commented Jun 1, 2023

@tjruwase Sorry to bother, but it's hard for me to understand what goes wrong in nv-mii / unit-tests task. Can you help me with that?

@tjruwase
Copy link
Contributor

tjruwase commented Jun 1, 2023

@tjruwase Sorry to bother, but it's hard for me to understand what goes wrong in nv-mii / unit-tests task. Can you help me with that?

This looks like a CI issue. Let me restart the CI.

@tjruwase tjruwase merged commit f5dde36 into microsoft:master Jun 1, 2023
@eggiter eggiter deleted the fix-3564 branch June 2, 2023 00:59
@eggiter eggiter mentioned this pull request Jun 2, 2023
Closed
molly-smith pushed a commit that referenced this pull request Jun 23, 2023
@eggiter @tjruwase @molly-smith
Fix RuntimeError when using ZeRO Stage3 with mpu: #3564 (#3565)
e92f7c9 
Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samadejacobs samadejacobs samadejacobs approved these changes

@jeffra jeffra Awaiting requested review from jeffra

@tjruwase tjruwase Awaiting requested review from tjruwase tjruwase is a code owner

@samyam samyam Awaiting requested review from samyam

@mrwyattii mrwyattii Awaiting requested review from mrwyattii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eggiter @tjruwase @samadejacobs