Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update yapf version and style settings #3098

Merged
merged 1 commit into from
Mar 27, 2023
Merged

update yapf version and style settings #3098

merged 1 commit into from
Mar 27, 2023

Conversation

jeffra
Copy link
Collaborator

@jeffra jeffra commented Mar 25, 2023

  • We have been using yapf from a mirror copy for years (https://github.com/pre-commit/mirrors-yapf) which is no longer maintained, the official version is now on github (https://github.com/google/yapf)
  • @stas00 and I had a discussion that our existing formatting settings are not great, this PR bumps up the character limit per line fro 89 -> 119 and also sets SPLIT_ALL_COMMA_SEPARATED_VALUES = false which in many cases made code unreadable.

@stas00
Copy link
Collaborator

stas00 commented Mar 25, 2023

Looks amazingly better - 2.5x less lines for wrapped lines! +5,259 −12,322

This should dramatically improve PR reviewing.

e.g. before:
snapshot_82

after:
snapshot_83

@tjruwase tjruwase merged commit 91d63e0 into master Mar 27, 2023
@mrwyattii mrwyattii deleted the update-style branch July 7, 2023 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants