-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DeepSpeed Communication Profiling and Logging #2012
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Quentin Anthony <qganthony@yahoo.com> Co-authored-by: Ammar Ahmad Awan <ammar.awan@microsoft.com> Co-authored-by: Jeff Rasley <jerasley@microsoft.com>
…pSpeed into staging-comms-next
Quentin-Anthony
requested review from
jeffra,
samyam,
tjruwase,
ShadenSmith,
conglongli,
awan-10,
cli99,
eltonzheng,
minjiaz and
RezaYazdaniAminabadi
as code owners
June 13, 2022 22:11
Quentin-Anthony
commented
Jun 30, 2022
Quentin-Anthony
commented
Jun 30, 2022
Quentin-Anthony
commented
Jun 30, 2022
Quentin-Anthony
commented
Jun 30, 2022
Quentin-Anthony
commented
Jun 30, 2022
Quentin-Anthony
commented
Jun 30, 2022
Quentin-Anthony
commented
Jun 30, 2022
Quentin-Anthony
commented
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been reviewed by Ammar
Quentin-Anthony
changed the title
DeepSpeed Communication Logging
DeepSpeed Communication Profiling and Logging
Jun 30, 2022
jeffra
reviewed
Jul 21, 2022
jeffra
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements logging for all DeepSpeed communication calls
This PR introduces the DeepSpeed Communication Logger
After this PR, all communication calls from #1985 are automatically detected and logged (depending on config options). A final summary is then printed. For example:
This PR contributes the following features:
log_summary
method)all_gather_zero3
)Co-authored-by: Quentin Anthony qganthony@yahoo.com
Co-authored-by: Ammar Ahmad Awan ammar.awan@microsoft.com
Co-authored-by: Jeff Rasley jerasley@microsoft.com