Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split parameter offload from z3 #2009

Merged
merged 16 commits into from
Jun 21, 2022
Merged

Split parameter offload from z3 #2009

merged 16 commits into from
Jun 21, 2022

Conversation

tjruwase
Copy link
Contributor

Parameter offloading can live separately from stage 3 optimizer, right?

@sgugger
Copy link

sgugger commented Jun 14, 2022

I can confirm that with this PR, I'm able to run CPU-offload on a 6B parameters models with limited RAM (32GB). Usage peaks at 24GB before going down to a constant 20GB.

The same test script crashes due to OOM on the last version of DeepSpeed.

@stas00
Copy link
Collaborator

stas00 commented Jun 14, 2022

Thank you for validating the fix, @sgugger!

Tunji, is it good to merge? as quite a few users are impacted by this memory issue and your PR would help to many. Thank you!

@tjruwase
Copy link
Contributor Author

@sgugger, thanks for validating this fix. @stas00, I will prioritize cleaning this up and getting the reviews.

@tjruwase tjruwase removed the request for review from RezaYazdaniAminabadi June 14, 2022 21:27
@tjruwase tjruwase enabled auto-merge (squash) June 16, 2022 16:43
@tjruwase tjruwase merged commit 678c3fe into master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants