launcher save pid + require manual triton install for sparse-attn #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffra
requested review from
awan-10,
cli99,
conglongli,
eltonzheng,
minjiaz,
RezaYazdaniAminabadi,
samyam,
ShadenSmith and
tjruwase
as code owners
tjruwase
reviewed
Jan 27, 2022
tjruwase
approved these changes
Jan 27, 2022
jeffra
changed the title
This was referenced Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When launching deepspeed processes programmatically it's useful to save the top-level launcher's process id (pid). This allows one method for cleaning up runner processes since if we kill the top-level launcher process than the children processes will be killed as well (on that worker).
Also removing auto-install of
tritondue to several issues with the triton 1.0.0 install we've seen (e.g., #1710).