Control ds_report output #1622
Merged
Control ds_report output #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors_and_warnings Separate cli and function entry points to ds_report
tjruwase
requested review from
awan-10,
cli99,
conglongli,
eltonzheng,
minjiaz,
RezaYazdaniAminabadi,
samyam and
ShadenSmith
as code owners
|
@stas00, FYI |
tjruwase
removed request for
ShadenSmith,
samyam,
conglongli,
awan-10,
cli99,
eltonzheng,
minjiaz and
RezaYazdaniAminabadi
|
@stas00 on the Megatron-DeepSpeed/BigScience side (once this PR is merged) we'll need to pass the appropriate flags ( |
jeffra
approved these changes
Dec 8, 2021
|
Perfect, thank you gentleman! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two flags to help control ds_report out:
Separate cli and function entry points into ds_report
Should fix #1541.