Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use py-cpuinfo to detect SIMD_WIDTH in platform-independent way #1616

Merged
merged 4 commits into from
Dec 11, 2021

Conversation

lostmsu
Copy link
Contributor

@lostmsu lostmsu commented Dec 8, 2021

This enables AVX2 and AVX512 detection on Windows.

@RezaYazdaniAminabadi
Copy link
Contributor

RezaYazdaniAminabadi commented Dec 8, 2021

Thanks @lostmsu for the PR 👍 I have tried this on AMD and Intel CPUs and both passed the unit test.

@lostmsu
Copy link
Contributor Author

lostmsu commented Dec 8, 2021

How do I correct formatting? The test does not tell what is wrong with it.

@jeffra
Copy link
Collaborator

jeffra commented Dec 8, 2021

How do I correct formatting?

Can you run our pre-commit formatter? See our contributor guide here: https://github.com/microsoft/DeepSpeed/blob/master/CONTRIBUTING.md#prerequisites

@lostmsu
Copy link
Contributor Author

lostmsu commented Dec 8, 2021

@jeffra you might want to make the formatting check run without requiring approval.

@jeffra jeffra enabled auto-merge (squash) December 9, 2021 19:57
Copy link
Collaborator

@jeffra jeffra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @lostmsu!

@lostmsu
Copy link
Contributor Author

lostmsu commented Dec 9, 2021

@jeffra do I need to look into the test failures?

@lostmsu
Copy link
Contributor Author

lostmsu commented Dec 10, 2021

@RezaYazdaniAminabadi @jeffra I have another commit built on top of this one to support CPU Adam and Adagrad on Windows: lostmsu@4daa425

Just nagging here to get this in so I could publish another PR )

@jeffra
Copy link
Collaborator

jeffra commented Dec 10, 2021

@jeffra do I need to look into the test failures?

We were seeing very strange test runner failures all day yesterday, for some reason tests would be marked Abandoned after 15min or running. We've been debugging and testing to see if we could resolve the issue but today it is "magically" working again, it might have been an intermittent github actions server-side issue. If tests pass now then we can merge this today.

@jeffra jeffra merged commit 64c2946 into microsoft:master Dec 11, 2021
@lostmsu lostmsu deleted the py-cpuinfo branch December 11, 2021 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants