-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use py-cpuinfo to detect SIMD_WIDTH in platform-independent way #1616
Conversation
Thanks @lostmsu for the PR 👍 I have tried this on AMD and Intel CPUs and both passed the unit test. |
How do I correct formatting? The test does not tell what is wrong with it. |
Can you run our |
@jeffra you might want to make the formatting check run without requiring approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @lostmsu!
@jeffra do I need to look into the test failures? |
@RezaYazdaniAminabadi @jeffra I have another commit built on top of this one to support CPU Adam and Adagrad on Windows: lostmsu@4daa425 Just nagging here to get this in so I could publish another PR ) |
We were seeing very strange test runner failures all day yesterday, for some reason tests would be marked Abandoned after 15min or running. We've been debugging and testing to see if we could resolve the issue but today it is "magically" working again, it might have been an intermittent github actions server-side issue. If tests pass now then we can merge this today. |
This enables AVX2 and AVX512 detection on Windows.