Fix many typos #1423
Merged
Fix many typos #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aphedges
requested review from
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
RezaYazdaniAminabadi,
samyam,
ShadenSmith and
tjruwase
as code owners
|
@aphedges, Oh wow!!! This is amazing. Thanks so much for taking the trouble to make this incredibly valuable contribution. |
tjruwase
approved these changes
Oct 1, 2021
|
awesome. |
|
@tjruwase, you're welcome! It surprisingly only took around 2 hours. I don't think the failing test is my fault from reading the error message, but I'm not entirely sure. |
B06901052
pushed a commit
to B06901052/DeepSpeed
that referenced
this pull request
Apr 14, 2022
* Fix typos in docs/ * Fix typos in code comments and output strings * Fix typos in the code itself * Fix typos in tests/ Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
B06901052
pushed a commit
to B06901052/DeepSpeed
that referenced
this pull request
Apr 14, 2022
* Fix typos in docs/ * Fix typos in code comments and output strings * Fix typos in the code itself * Fix typos in tests/ Co-authored-by: Olatunji Ruwase <olruwase@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After I came across some typos in the documentation and code while debugging, I decided to just run PyCharm's spellcheck on the entire repository. I was generally conservative, only making changes if I had a high confidence it was wrong. I probably missed a lot of typos, but this is still an improvement.
I tried to split the changes up into several commits for easier reviewing, but it's still a large diff. Let me know if I should make it more granular or if I should split it up into multiple commits.
There are also a couple of changes that modify identifiers like variable and function names. If you think they can cause compatibility issues, I will remove them. It's just hard to tell what code is part of the official API and what is not.