[zero3] release tmp memory when consolidating fp16 weights #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stas00
requested review from
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
RezaYazdaniAminabadi,
samyam,
ShadenSmith and
tjruwase
as code owners
tjruwase
approved these changes
Jul 12, 2021
stas00
added a commit
to stas00/DeepSpeed
that referenced
this pull request
Jul 12, 2021
microsoft#1220 fixed the leak, but lead to another problem. reverting that part so that we could do release and will work on it after the release. @jeffra
Merged
jeffra
pushed a commit
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
GatheredParameterswithmodifier_rank=Nonedoesn't release memory until the param is used next time some time in the future. As a result_zero3_consolidated_fp16_state_dictwas leaking memory. This PR uses the read/write mode which re-partitions the memory right away and releases the temporarily gathered params.@tjruwase