Skip to content

Commit

Permalink
Unpin accelerate tests, update lightning with node16 removal. (#6611)
Browse files Browse the repository at this point in the history
HF accelerate fixes implemented in
huggingface/accelerate#3145 mean that we no
longer need to pin the Accelerate version!

nv-lightning tests now run on Ubuntu 20.04+, so we support >node 16, so
we can remove the explicit permissions for that in the env config.
  • Loading branch information
loadams authored Oct 9, 2024
1 parent 645639b commit 1062a0c
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion .github/workflows/nv-accelerate-v100.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ jobs:
unset TORCH_CUDA_ARCH_LIST # only jit compile for current arch
git clone https://github.com/huggingface/accelerate
cd accelerate
git checkout ae9cb6e4db6f81fd18148c2cc67d72b903d81a46
git rev-parse --short HEAD
# installing dependencies
pip install .[testing]
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/nv-lightning-v100.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ jobs:
unit-tests:
runs-on: [self-hosted, nvidia, cu121, v100]

env: {ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true} # Allow using Node16 actions

steps:
- uses: actions/checkout@v3

Expand Down

0 comments on commit 1062a0c

Please sign in to comment.