Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mitigate the risk of deadlock #274

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Mitigate the risk of deadlock #274

merged 1 commit into from
Nov 8, 2023

Conversation

tohtana
Copy link
Contributor

@tohtana tohtana commented Nov 8, 2023

This PR includes:

  • Display message when we fall into the deadlock caused by inefficient KV cache
  • Keep some margin when scheduling requests

cmikeh2
cmikeh2 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@cmikeh2 cmikeh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if I'm sufficient to approve a review here for merge, but I like this 😄

@mrwyattii mrwyattii merged commit a0f55c2 into main Nov 8, 2023
3 checks passed
@mrwyattii mrwyattii deleted the tohtana/mitigate-deadlock branch November 8, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrwyattii mrwyattii mrwyattii approved these changes

@cmikeh2 cmikeh2 cmikeh2 approved these changes

@jeffra jeffra Awaiting requested review from jeffra

@awan-10 awan-10 Awaiting requested review from awan-10 awan-10 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tohtana @cmikeh2 @mrwyattii