dotnet build's parameter NetCoreBuild is not defined

[kev1010]

Read me documents the build process with:
dotnet build /p:NetCoreBuild=true

However, dotnet build does not define the NetCoreBuild parameter. Where can I find the documentation for this parameter?

[ErikEJ]

You do not need it with the latest SDK version

[kev1010]

This is a question about the documentation in the repository.

[stijnherreman]

/p parameters in general are documented at https://learn.microsoft.com/en-us/dotnet/core/tools/dotnet-build#msbuild

NetCoreBuild is not a generic parameter, it is specific to this SDK. You can see how it is used in

DacFx/src/Microsoft.Build.Sql/sdk/Sdk.targets

Lines 10 to 12 in 61888b2

	<Import Condition="'$(NetCoreBuild)' == 'true'" Project="$(MSBuildThisFileDirectory)../tools/netstandard2.1/Microsoft.Data.Tools.Schema.SqlTasks.targets"/>
	<Import Condition="'$(NetCoreBuild)' != 'true' AND '$(SQLDBExtensionsRefPath)' != ''" Project="$(SQLDBExtensionsRefPath)\Microsoft.Data.Tools.Schema.SqlTasks.targets" />
	<Import Condition="'$(NetCoreBuild)' != 'true' AND '$(SQLDBExtensionsRefPath)' == ''" Project="$(MSBuildExtensionsPath)\Microsoft\VisualStudio\v$(VisualStudioVersion)\SSDT\Microsoft.Data.Tools.Schema.SqlTasks.targets" />

Instead of passing the parameter via dotnet build, you can also configure it in your sqlproj instead:

  <PropertyGroup>
    <NetCoreBuild>true</NetCoreBuild>
  </PropertyGroup>

However, as ErikEJ says, this is no longer necessary with the latest SDK version 0.1.7-preview.

[kev1010]

Thank you @stijnherreman and @ErikEJ for your responses. It seems this parameter was used for integration with SSDT based on this comment in the Readme file:
Note: Building with .NET Core targets is currently unsupported in SSDT. Please make sure the NetCoreBuild property is false or not defined when building in SSDT.
From the comments in our discussion, it seems like this limitation is no longer a concern. Therefore, shouldn't the parameter be removed altogether to clean up the code?

I have referenced this thread in PR 191 where the author is updating other documentation to version 0.1.7-preview.

[zijchen]

The NetCoreBuild property is still needed for the build process to load the correct assemblies. When you build with dotnet build, NetCoreBuild is true and it will use the assemblies packaged in this SDK. When you build with SSDT, NetCoreBuild is false and it will use the assemblies installed by SSDT. The latest SDK version just handles setting the property for you.

We hope to clean this up so SSDT also uses the assemblies from the SDK.

[kev1010]

Why is it so complicated to make them both use the same build? Wouldn't it just be changing it to use the same? In any case, it would be helpful for it to be documented in the help file so people would know what and why the builds are doing what they do.

…

On Thu, Dec 1, 2022, 5:17 PM Z Chen ***@***.***> wrote: The NetCoreBuild property is still needed for the build process to load the correct assemblies. When you build with dotnet build, NetCoreBuild is true and it will use the assemblies packaged in this SDK. When you build with SSDT, NetCoreBuild is false and it will use the assemblies installed by SSDT. The latest SDK version just handles setting the property for you. We hope to clean this up so SSDT also uses the assemblies from the SDK. — Reply to this email directly, view it on GitHub <#186 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AYEG2E7ZFHVDN5GNW73FKN3WLEPYPANCNFSM6AAAAAASGGOOOQ> . You are receiving this because you authored the thread.Message ID: ***@***.***>