Fix assembly lookup for type reference (IIDOptimizer) #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j0shuams
commented
Aug 28, 2021
src/Samples/WinAppSdkSample/WinAppSdkSample (Package)/Package.appxmanifest
Outdated
Show resolved
Hide resolved
j0shuams
commented
Aug 28, 2021
src/Samples/WinAppSdkSample/WinAppSdkSample/Directory.Build.targets
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Aug 30, 2021
src/Samples/WinAppSdkSample/WinAppSdkSample.Package/WinAppSdkSample.Package.wapproj
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Aug 30, 2021
src/Samples/WinAppSdkSample/WinAppSdkSample/Directory.Build.props
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Aug 30, 2021
src/Samples/WinAppSdkSample/WinAppSdkSample/WinAppSdkSample.csproj
Outdated
Show resolved
Hide resolved
|
Consider removing the cache file as it is a binary file and probably want to remove the pfx file too. |
manodasanW
reviewed
Aug 31, 2021
manodasanW
approved these changes
Aug 31, 2021
|
Using private ProjectReunion build, verified the fix works on both net5 and net6 apps -- including Ready2Run scenarios / Publish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WinAppSDK 0.8.2 had a regression because of an issue with the IIDOptimizer. When adding a type reference in the IL, the wrong assembly was used to lookup the definition (e.g. it was failing to find a type in Microsoft.WinUI.dll that was really in WinRT.Runtime.dll).
To test this fix, I have
addeda sample app that uses the Windows App SDK. This is a good to have for future testing of WinUI/WinApp bugs. I took out the sample app as it required updating the ObjectLifetimeTests to a newer Reunion version, and that caused a lot of headaches. I will add the sample app as part of the work here - #778.Fixes #971