Interop interfaces are all pass-by-ref for IID param #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any impact to the Windows SDK projection public API surface / assembly version from this change? I see all the types that were modified had ProjectionInternal, but want to confirm there is indeed no impact. |
There shouldn't be any impact - the interop IDL is used solely to generate projection sources for the Windows SDK |
manodasanW
reviewed
Jun 22, 2021
manodasanW
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #885
fixed interop IDL, and decided to just keep the TestHWND I created earlier (when I thought it was an HWND marshaling issue)
Note that:
for 64-bit calling convention, a 128-bit value ends up being passed by address, so we get lucky
for 32-bit calling convention, a 128-bit value is passed directly on the stack, so we get corruption when the callee attempts to interpret the first 4 bytes of that GUID as a pointer to one.