Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address potential races in recent event changes #882

Merged
merged 4 commits into from
Jun 17, 2021

Conversation

manodasanW
Copy link
Member

  • If an event source tries to invoke a handler right after it is added, it won't invoke any registered handlers as we set them up after. Fixing the ordering for it.
  • Previously before the event handler optimizations, we stored the delegate in a local before invoking it to prevent races with it being removed. Putting that back in to avoid that race.

@manodasanW manodasanW merged commit d607f3e into master Jun 17, 2021
@manodasanW manodasanW deleted the manodasanw/potentialfix branch June 17, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants