Rework Fast Up To Date checks to correctly capture cs:winmd relationship #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manodasanW
reviewed
Jun 16, 2021
| @@ -110,12 +110,13 @@ $(CsWinRTIncludeWinRTInterop) | |||
| <WriteLinesToFile File="$(CsWinRTResponseFile)" Lines="$(CsWinRTParams)" Overwrite="true" WriteOnlyWhenDifferent="true" /> | |||
| <Message Text="$(CsWinRTCommand)" Importance="$(CsWinRTMessageImportance)" /> | |||
| <Exec Command="$(CsWinRTCommand)" /> | |||
| <!--To support Visual Studio's FastUpToDate builds, we need to cpature the CsWinRT relationship of *.cs: *.winmd. | |||
srdjanjovcic
approved these changes
Jun 16, 2021
manodasanW
approved these changes
Jun 16, 2021
|
Looks like this breaks the build when WinRT.cs doesn't get created. Specifically the one in authoring is that they are all generated in a temp dir and then fed to a source geneator. For authoring scenarios, we don't need to do this as it would be handled by the source generator so I think can do a conditional check on it to exclude those scenarios. |
…ft/CsWinRT into scottj1s/fast_up_to_date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #879
see related issue:
Visual Studio Fast Up To Date build not working - CopyComplete marker is touched when no files are copied · Issue #7326 · dotnet/project-system (github.com)