User/shasnayak/port object lifetime tests #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azchohfi
reviewed
May 18, 2021
src/Tests/ObjectLifetimeTests/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted/UnitTest.cs
Outdated
Show resolved
Hide resolved
azchohfi
reviewed
May 18, 2021
...ests/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted.csproj
Outdated
Show resolved
Hide resolved
azchohfi
reviewed
May 18, 2021
src/Tests/ObjectLifetimeTests/ObjectLifetimeTests.Tests/ObjectLifetimeTests.Tests.csproj
Outdated
Show resolved
Hide resolved
codendone
reviewed
May 18, 2021
...sts.Lifted/ObjectLifetimeTests.Lifted (Package)/ObjectLifetimeTests.Lifted (Package).wapproj
Outdated
Show resolved
Hide resolved
codendone
reviewed
May 18, 2021
ShashankNay
requested review from
Scottj1s,
manodasanW,
evelynwu-msft and
MikeHillberg
manodasanW
reviewed
May 20, 2021
...ests/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted.csproj
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
May 20, 2021
src/Tests/ObjectLifetimeTests/ObjectLifetimeTests.Lifted/nuget.config
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
May 20, 2021
src/Tests/ObjectLifetimeTests/ObjectLifetimeTests.Wux/ObjectLifetimeTests.Wux.csproj
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
May 20, 2021
manodasanW
reviewed
May 20, 2021
manodasanW
reviewed
May 20, 2021
manodasanW
reviewed
May 20, 2021
manodasanW
reviewed
May 20, 2021
manodasanW
reviewed
May 20, 2021
src/Tests/ObjectLifetimeTests/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted.sln
Outdated
Show resolved
Hide resolved
Scottj1s
reviewed
Jun 1, 2021
...jectLifetimeTests/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted/Package.appxmanifest
Outdated
Show resolved
Hide resolved
Scottj1s
reviewed
Jun 1, 2021
...jectLifetimeTests/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted/Package.appxmanifest
Outdated
Show resolved
Hide resolved
Scottj1s
reviewed
Jun 1, 2021
| public App() | ||
| { | ||
| this.InitializeComponent(); | ||
| this.Suspending += OnSuspending; |
There was a problem hiding this comment.
the suspending event is experimental - should remove it (and handler)
Scottj1s
reviewed
Jun 1, 2021
|
|
||
| <Identity | ||
| Name="2cbb106a-c4fb-4dc8-8e72-f0727f24f544" | ||
| Publisher="CN=mikeh" |
Scottj1s
reviewed
Jun 1, 2021
| <mp:PhoneIdentity PhoneProductId="2cbb106a-c4fb-4dc8-8e72-f0727f24f544" PhonePublisherId="00000000-0000-0000-0000-000000000000"/> | ||
|
|
||
| <Properties> | ||
| <DisplayName>ObjectLifetimeTests0325</DisplayName> |
Scottj1s
reviewed
Jun 1, 2021
src/Tests/ObjectLifetimeTests/ObjectLifetimeTests.Wux/Package.appxmanifest
Outdated
Show resolved
Hide resolved
Scottj1s
reviewed
Jun 1, 2021
Scottj1s
reviewed
Jun 1, 2021
...ests/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted/ObjectLifetimeTests.Lifted.csproj
Outdated
Show resolved
Hide resolved
src/build.cmd
Outdated
| @@ -121,6 +121,8 @@ if not exist %nuget_dir%\nuget.exe powershell -Command "Invoke-WebRequest https: | |||
| rem Note: packages.config-based (vcxproj) projects do not support msbuild /t:restore | |||
| call %this_dir%get_testwinrt.cmd | |||
| call :exec %nuget_dir%\nuget.exe restore %nuget_params% %this_dir%cswinrt.sln | |||
| rem: Calling nuget restore again on ObjectLifetimeTests.Lifted.csproj to prevent .props from \microsoft.testplatform.testhost\build\netcoreapp2.1 from being included. Nuget.exe erroneously imports props files. | |||
There was a problem hiding this comment.
Would also add a link to the bug causing this, NuGet/Home#9672
ShashankNay
force-pushed
the
user/shasnayak/port_object_lifetime_tests
branch
from
b837a6b
to
c4985c8
Compare
manodasanW
reviewed
Jun 29, 2021
src/Tests/ObjectLifetimeTests/ObjectLifetimeTests.Tests/ObjectLifetimeTests.Tests.csproj
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Jun 29, 2021
manodasanW
reviewed
Jun 29, 2021
manodasanW
reviewed
Jun 29, 2021
manodasanW
reviewed
Jun 29, 2021
manodasanW
reviewed
Jun 29, 2021
src/Tests/ObjectLifetimeTests/ObjectLifetimeTests.Tests/ObjectLifetimeTests.Tests.csproj
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Jun 29, 2021
src/Tests/ObjectLifetimeTests/ObjectLifetimeTests.Lifted/Directory.Build.props
Outdated
Show resolved
Hide resolved
manodasanW
reviewed
Jun 30, 2021
manodasanW
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a series of Object Lifetime tests that detect memory leaks using MSTest.