Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IsPartial check and escaping of assembly name #1802

Merged
merged 5 commits into from
Sep 29, 2024

Conversation

manodasanW
Copy link
Member

  • We previously didn't escape - and @ in the assembly name when using it for an identifier or namespace. This addresses that.
  • Our IsPartial check wasn't complete where we didn't also check whether the parent classes were partial too to allow for us to generate source. Due to that, we would generate source in such cases leading to a compiler error rather than raising a diagnostic as we did when the type itself wasn't partial.
  • Improve the code fixer to handle making parent types partial.
  • Add partial diagnostics for the GeneratedCustomBindableProperty attribute too

Fixes #1799
Fixes #1800

@manodasanW
Copy link
Member Author

Failures are post build infra issues, tests passed.

@manodasanW manodasanW merged commit 3e1724e into master Sep 29, 2024
6 of 9 checks passed
@manodasanW manodasanW deleted the manodasanw/fixpartial branch September 29, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants