-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit GUID support for delegates and non-synthesized interfaces. #1792
Add explicit GUID support for delegates and non-synthesized interfaces. #1792
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please also add a couple tests for various cases in the authoring test project?
I've added a test in, though I haven't personally tested it myself as I couldn't get CsWinRT to build. |
CI is not running because this is a fork. I cherry-picked to a branch here to kick it off, it's here. |
Fixed a typo, new CI run here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green (just failing on publish, unrelated), changes look good to me.
Thank you! 🙂
I'm not too sure about synthesized interfaces, as it looks like multiple might be generated?
Closes #1790