Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit GUID support for delegates and non-synthesized interfaces. #1792

Merged

Conversation

dongle-the-gadget
Copy link
Contributor

I'm not too sure about synthesized interfaces, as it looks like multiple might be generated?

Closes #1790

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please also add a couple tests for various cases in the authoring test project?

@dongle-the-gadget
Copy link
Contributor Author

I've added a test in, though I haven't personally tested it myself as I couldn't get CsWinRT to build.

@Sergio0694
Copy link
Member

CI is not running because this is a fork. I cherry-picked to a branch here to kick it off, it's here.

@Sergio0694
Copy link
Member

Fixed a typo, new CI run here.

Copy link
Member

@Sergio0694 Sergio0694 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green (just failing on publish, unrelated), changes look good to me.
Thank you! 🙂

@manodasanW manodasanW merged commit 037f6ae into microsoft:master Sep 18, 2024
1 check passed
@dongle-the-gadget dongle-the-gadget deleted the authoring-explicit-guid branch September 19, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Authoring] Allow setting GuidAttributes for types
4 participants