Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor trimming optimizations for authoring #1396

Merged
merged 4 commits into from
Jan 9, 2024
Merged

Minor trimming optimizations for authoring #1396

merged 4 commits into from
Jan 9, 2024

Conversation

Sergio0694
Copy link
Member

This PR includes two small tweaks for trimming in authoring scenarios:

  • Remove an unnecessary DynamicallyAccessedMemberTypes.PublicFields flag in TryAs<T>
  • Use IActivationFactoryMethods.IID to resolve the activation factory from Make()

@Sergio0694 Sergio0694 added authoring Related to authoring feature work AOT labels Nov 26, 2023
Sergio0694
Sergio0694 commented Dec 1, 2023
View reviewed changes
src/cswinrt/code_writers.h Outdated Show resolved Hide resolved
@Sergio0694 Sergio0694 mentioned this pull request Jan 8, 2024
Closed
@Sergio0694 Sergio0694 merged commit 8bb64f5 into staging/AOT Jan 9, 2024
9 checks passed
@Sergio0694 Sergio0694 deleted the user/sergiopedri/aot-tweaks branch January 9, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaanstra jlaanstra jlaanstra approved these changes

@manodasanW manodasanW manodasanW approved these changes

Assignees
No one assigned
Labels
AOT authoring Related to authoring feature work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sergio0694 @jlaanstra @manodasanW