Remove Resurrect logic as it shouldn't be needed for .NET 6 and newer. #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaanstra
force-pushed
the
user/jlaans/remove-resurrect
branch
from
d5b7249
to
9d04677
Compare
Sergio0694
requested changes
Jan 8, 2024
Sergio0694
force-pushed
the
user/jlaans/remove-resurrect
branch
from
cc32b1e
to
7c9fe67
Compare
jlaanstra
force-pushed
the
user/jlaans/remove-resurrect
branch
from
7c9fe67
to
52a3feb
Compare
|
Confirmed using both .NET 6 and .NET 8 with the old repro app that this change runs without issue. |
manodasanW
approved these changes
Jan 25, 2024
Sergio0694
pushed a commit
that referenced
this pull request
Jan 25, 2024
#1380) * Remove Resurrect logic as it shouldn't be needed for .NET 6 and newer. * Remove double check. * Add check back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After talking with @manodasanW we should no longer need Resurrect on .NET 6 and newer.