Skip to content

Ensure WinRT.Runtime stability with embedded constant #1138

Open

Description

We had an issue where a couple of new types in WinRT.Runtime didn't get the #if EMBED treatment needed. We should add an analyzer (or better a codefix) to WinRT.Runtime to prevent this in the future.

E.g.

namespace SomeWinRTRuntimeTypeFamily
{
  public IEnumerable<Foo> NewType = ...;
}

becomes (with codefix or after being warned by an analyzer)

namespace SomeWinRTRuntimeTypeFamily
{
#if EMBED
  internal
#else
  public 
#endif
  IEnumerable<Foo> NewType = ...;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions