Skip to content

Observe DangerousAddRef result before proceeding. #762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 11, 2022
Merged

Observe DangerousAddRef result before proceeding. #762

merged 2 commits into from
Nov 11, 2022

Conversation

@AArnott
Copy link
Member

@AArnott AArnott commented Nov 11, 2022

Fixes #754

@AArnott AArnott enabled auto-merge November 11, 2022 15:03
@AArnott AArnott merged commit c3de6fe into main Nov 11, 2022
@AArnott AArnott deleted the fix754 branch November 11, 2022 16:18
@AaronRobinsonMSFT
Copy link
Member

This isn't necessary. Sorry for the slow reply. The DangerousAddRef will throw on failure to add ref.

@AArnott
Copy link
Member Author

AArnott commented Nov 11, 2022

Thanks, @AaronRobinsonMSFT. I'll revert this change.

@AArnott AArnott mentioned this pull request Nov 11, 2022
Merged
@dependabot dependabot bot mentioned this pull request Sep 15, 2025
Closed
@dependabot dependabot bot mentioned this pull request Oct 20, 2025
Closed
@dependabot dependabot bot mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SafeHandle to typedef conversion should not ignore AddRef failure

3 participants

@AArnott @AaronRobinsonMSFT