Latest CsWin32 generates code that fail to compile (and unnecessary methods)

[Sergio0694]

Actual behavior

I've updated to the latest version (0.3.162) and my project is now failing to compile. Upon inspecting the generated code, it seems CsWin32 is generating a bunch of invalid code in the QueryInterface methods it's emitting. It's also not clear why these methods are generated in the first place, given I've disabled the friendly overloads. I expect (and want) literally only the vtable methods to be generated, nothing else.

You can see this generated call has invalid arguments. Also, this whole method shouldn't be generated at all, really.

Expected behavior

The code should be valid and compile, and no additional "helper methods" should be generated.

Repro steps

1. NativeMethods.txt content:

ID3D11ShaderReflection
IUnknown

2. NativeMethods.json content (if present):

{
  "$schema": "https://aka.ms/CsWin32.schema.json",
  "allowMarshaling": false,
  "useSafeHandles": false,
  "comInterop": {
    "preserveSigMethods": [
      "*"
    ]
  },
  "friendlyOverloads": {
    "enabled": false
  }
}

Context

• CsWin32 version: 0.3.162
• Win32Metadata version (if explicitly set by project): n/a
• Target Framework: netstandard2.0 and net9.0 (I can repro on both)
• LangVersion (if explicitly set by project): n/a

[Sergio0694]

The codegen with 0.3.106 is correct. It's 0.3.162 (the latest) that's all wrong:

• It produces invalid code
• It adds a whole lot of random helper methods and unnecessary stuff I never asked for

Eg. why is it even trying to emit ComWrappers marshalling code if I specifically asked for no marshalling? I only want blittable stuff.

[Sergio0694]

@AArnott the build break was caused by #1290. That new method is:

• Wrong for when blittable mode is used, as the parameter types don't match
• It shouldn't be generated in the first place when friendly overloads are disabled

Same for other random helper methods that should be removed, but at least those are not breaking 😅

[AArnott]

@Sergio0694 Thank you for your report.

I couldn't readily identify any methods besides the faulty QueryInterface method itself that should be omitted when friendly overloads are turned off. Please open a separate bug listing any other methods you feel are being generated inappropriately.

[Sergio0694]

I opened #1338 as a follow up 🙂